sql: fix flaky role logic test#92303
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Nov 23, 2022
Merged
Conversation
The role IDs are not important to this test, and were causing flakiness since the backing sequence may generate IDs with gaps. Release note: None
Member
|
This change is |
ZhouXing19
approved these changes
Nov 22, 2022
Collaborator
ZhouXing19
left a comment
There was a problem hiding this comment.
Do we need to backport this?
Collaborator
Author
|
i'll backport to 22.2, which is when this test was changed to have these IDs. tftr! bors r=ZhouXing19 |
Contributor
|
Build failed (retrying...): |
Contributor
|
Build failed (retrying...): |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #92164
The role IDs are not important to this test, and were causing flakiness since the backing sequence may generate IDs with gaps.
Release note: None