Skip to content

ui: show stmt idle time in execution/planning chart#92284

Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom
matthewtodd:idle_lat-stmt-ui
Nov 22, 2022
Merged

ui: show stmt idle time in execution/planning chart#92284
craig[bot] merged 1 commit intocockroachdb:masterfrom
matthewtodd:idle_lat-stmt-ui

Conversation

@matthewtodd
Copy link
Copy Markdown

@matthewtodd matthewtodd commented Nov 21, 2022

Part of #86667.

The example statement fingerprint below comes from me connecting to a local cockroach instance with psql (since cockroach sql by default runs a few extra queries that confuse the timings) and individually running the following lines to simulate some inter-statement latency:

BEGIN;
SELECT 1;
COMMIT;
Before After
Screen Shot 2022-11-21 at 2 35 49 PM Screen Shot 2022-11-21 at 2 35 58 PM

Release note (ui change): The "Statement Execution and Planning Time" chart on the statement fingerprint page now includes a third value, "Idle," representing the time spent by the application waiting to execute this statement while holding a transaction open.

@cockroach-teamcity
Copy link
Copy Markdown
Member

This change is Reviewable

Part of #86667.

Release note (ui change): The "Statement Execution and Planning Time"
chart on the statement fingerprint page now includes a third value,
"Idle," representing the time spent by the application waiting to
execute this statement while holding a transaction open.
@matthewtodd matthewtodd marked this pull request as ready for review November 22, 2022 01:05
@matthewtodd matthewtodd requested a review from a team November 22, 2022 01:06
Copy link
Copy Markdown

@ericharmeling ericharmeling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (waiting on @matthewtodd)

@matthewtodd
Copy link
Copy Markdown
Author

bors r+

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Nov 22, 2022

Build failed (retrying...):

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Nov 22, 2022

Build failed (retrying...):

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Nov 22, 2022

Build failed (retrying...):

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Nov 22, 2022

Build succeeded:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants