ui: show stmt idle time in execution/planning chart#92284
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Nov 22, 2022
matthewtodd:idle_lat-stmt-ui
Merged
ui: show stmt idle time in execution/planning chart#92284craig[bot] merged 1 commit intocockroachdb:masterfrom matthewtodd:idle_lat-stmt-ui
craig[bot] merged 1 commit intocockroachdb:masterfrom
matthewtodd:idle_lat-stmt-ui
Conversation
Member
Part of #86667. Release note (ui change): The "Statement Execution and Planning Time" chart on the statement fingerprint page now includes a third value, "Idle," representing the time spent by the application waiting to execute this statement while holding a transaction open.
ericharmeling
approved these changes
Nov 22, 2022
ericharmeling
left a comment
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @matthewtodd)
Author
|
bors r+ |
Contributor
|
Build failed (retrying...): |
Contributor
|
Build failed (retrying...): |
Contributor
|
Build failed (retrying...): |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #86667.
The example statement fingerprint below comes from me connecting to a local cockroach instance with
psql(sincecockroach sqlby default runs a few extra queries that confuse the timings) and individually running the following lines to simulate some inter-statement latency:Release note (ui change): The "Statement Execution and Planning Time" chart on the statement fingerprint page now includes a third value, "Idle," representing the time spent by the application waiting to execute this statement while holding a transaction open.