Skip to content

dev-inf: Add T-multitenant label to multi-tenant#92280

Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom
ajstorm:ajstorm-teams-update
Nov 21, 2022
Merged

dev-inf: Add T-multitenant label to multi-tenant#92280
craig[bot] merged 1 commit intocockroachdb:masterfrom
ajstorm:ajstorm-teams-update

Conversation

@ajstorm
Copy link
Copy Markdown
Collaborator

@ajstorm ajstorm commented Nov 21, 2022

Added the t-multitenant lable to the multi-tenant section of TEAMS.yaml

Release note: None

Epic: None

@ajstorm ajstorm requested a review from knz November 21, 2022 19:16
@cockroach-teamcity
Copy link
Copy Markdown
Member

This change is Reviewable

Copy link
Copy Markdown
Contributor

@knz knz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

you might want to remove triage_column_id since that refers to the now-obsolete board.

@ajstorm ajstorm force-pushed the ajstorm-teams-update branch from e92e99c to 597c94f Compare November 21, 2022 20:16
@ajstorm
Copy link
Copy Markdown
Collaborator Author

ajstorm commented Nov 21, 2022

I removed the stale column tag. TFTR!

bors r=knz

triage_column_id: 14196277
cockroachdb/multi-tenant:
triage_column_id: 16575985
label: T-multitenant
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this have the intended effect? i would expect that you'd need to also update the Team struct in pkg/internal/team/team.go

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh i see it now. i needed a rebase

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Nov 21, 2022

Build succeeded:

@craig craig bot merged commit 0354b67 into cockroachdb:master Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants