roachtest: jepsen reenable subcritical-skews tests#92125
Open
aliher1911 wants to merge 1 commit intocockroachdb:masterfrom
Open
roachtest: jepsen reenable subcritical-skews tests#92125aliher1911 wants to merge 1 commit intocockroachdb:masterfrom
aliher1911 wants to merge 1 commit intocockroachdb:masterfrom
Conversation
Member
|
This change is |
Tests were disabled due to hardcoded ntp.ubuntu.org throttling requests. Now that dependency is updated to pool.ntp.org we should see no throttling hopefully. In worst case we can switch to ntp.google.com again. Release note: None
e117fff to
6ed56ec
Compare
srosenberg
approved these changes
Nov 18, 2022
Member
srosenberg
left a comment
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @renatolabs and @smg260)
|
@aliher1911 - Any reason not to merge this PR? Maybe just on master at this point in case it does still have flakes? |
herkolategan
approved these changes
Aug 11, 2023
Collaborator
herkolategan
left a comment
There was a problem hiding this comment.
Should we merge this and un-skip to check if it's still flaky after?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests were disabled due to hardcoded ntp.ubuntu.org throttling requests. Now that dependency is updated to pool.ntp.org we should see no throttling hopefully. In worst case we can switch to ntp.google.com again.
Release note: None
Fixes #35599