upgrade: minor cleanups#91998
Merged
craig[bot] merged 2 commits intocockroachdb:masterfrom Nov 16, 2022
Merged
Conversation
Upgrades were taking a reference to the job running them. Once upon a time, this was allegedly used by some upgrade in order to checkpoint its progress. Nobody uses it currently, and this patch removes it. We can add it back if we need it again. This reference was in my way because in cockroachdb#91627 I'm adding a testing mode where upgrades do not run in jobs. Release note: None
Member
|
This change is |
ajwerner
approved these changes
Nov 16, 2022
Contributor
ajwerner
left a comment
There was a problem hiding this comment.
Reviewed 26 of 26 files at r1, 19 of 19 files at r2, all commit messages.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @andreimatei)
A lot of functions and structures were using the more complicated clusterversion.ClusterVersion where roachpb.Version is all they need. ClusterVersion is not plain data, so it was awkward to use it as map keys and such. Release note: None Epic: None
7d58778 to
b258d20
Compare
andreimatei
commented
Nov 16, 2022
Contributor
Author
andreimatei
left a comment
There was a problem hiding this comment.
bors r+
Reviewable status:
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See individual commits.
Extracted from #91627
Release note: None
Epic: None