sql: skip doc generation for CREATE/ALTER TENANT#91995
sql: skip doc generation for CREATE/ALTER TENANT#91995adityamaru wants to merge 1 commit intocockroachdb:masterfrom
Conversation
|
This change is |
f9005b5 to
567c290
Compare
| // %Text: | ||
| // ALTER TENANT { <tenant_id> | ALL } SET CLUSTER SETTING <var> { TO | = } <value> | ||
| // ALTER TENANT { <tenant_id> | ALL } RESET CLUSTER SETTING <var> | ||
| // %SeeAlso: SET CLUSTER SETTING |
There was a problem hiding this comment.
could these still be here so that if we do start generating docs we have it already?
There was a problem hiding this comment.
I believe this also populates the output of \h ALTER TENANT which is something we want to hide as well.
| if err := p.RequireAdminRole(ctx, op); err != nil { | ||
| return roachpb.TenantID{}, err | ||
| } | ||
| if err := rejectIfCantCoordinateMultiTenancy(p.ExecCfg().Codec, op); err != nil { |
There was a problem hiding this comment.
rejectIfCantCoordinateMultiTenancy ensures that only the system tenant can call CreateTenant. Previously, CreateTenant would fail later when it goes to write to system.tenants since that table doesn't exist in a secondary tenant. Instead, we get a better error by calling this method at the top of CreateTenant.
Release note: None
567c290 to
1023422
Compare
lidorcarmel
left a comment
There was a problem hiding this comment.
this pr looks correct, but let's first decide whether we need to drop or keep all of that?
Reviewed 8 of 9 files at r1, 3 of 3 files at r2, all commit messages.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @adityamaru and @rafiss)
docs/generated/sql/bnf/stmt_block.bnf line 2240 at r2 (raw file):
( role_option ) ( ( role_option ) )* typed_literal ::=
why did some blocks move? if we have to move some things maybe worth putting those in a separate commit?
|
@adityamaru do we need this PR still? |
I'm going to close this as it'll be easier to open a new PR given how much everything has changed. I've filed #97064 to track this. |
Release note: None