loqrecovery,admin: endpoints for loss of quorum recovery#91849
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Dec 6, 2022
Merged
loqrecovery,admin: endpoints for loss of quorum recovery#91849craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Member
|
This change is |
305cdc7 to
7572a43
Compare
1f66ed4 to
b6f028b
Compare
596e6e8 to
716c261
Compare
erikgrinaker
reviewed
Dec 6, 2022
pkg/server/admin.go
Outdated
| request *serverpb.RecoveryCollectReplicaInfoRequest, | ||
| server serverpb.Admin_RecoveryCollectReplicaInfoServer, | ||
| ) error { | ||
| panic("To be implemented by #93040") |
Contributor
There was a problem hiding this comment.
Return errors.AssertionFailedf, otherwise this is a trivial DoS vector that's accessible via the network.
Contributor
There was a problem hiding this comment.
On second thought, maybe we have a panic handler that would catch it. Either way, AssertionFailedf is more appropriate when we have an error return path.
This commit adds necessary protobufs and Admin rpc's for half online loss of quorum recovery tooling. Release note: None
716c261 to
4f71924
Compare
Contributor
Author
|
TFTR |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds necessary protobufs for half online loss of quorum recovery tooling.
Release note: None
Fixes #93037