Skip to content

storage: make storage.mvcc.range_tombstones.enabled tenant-readable#91824

Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom
erikgrinaker:mvcc-range-tombstones-tenant-readonly
Nov 14, 2022
Merged

storage: make storage.mvcc.range_tombstones.enabled tenant-readable#91824
craig[bot] merged 1 commit intocockroachdb:masterfrom
erikgrinaker:mvcc-range-tombstones-tenant-readonly

Conversation

@erikgrinaker
Copy link
Copy Markdown
Contributor

@erikgrinaker erikgrinaker commented Nov 14, 2022

This setting needs to be readable by tenants, in order to be used by schema GC and import jobs.

Appropriate tests will be added separately.

Epic: CRDB-2624

Release note: None

@cockroach-teamcity
Copy link
Copy Markdown
Member

This change is Reviewable

This setting needs to be readable by tenants, in order to be used by
schema GC and import jobs.

Appropriate tests will be added separately.

Release note: None
Copy link
Copy Markdown
Collaborator

@stevendanna stevendanna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is the best we can probably do for now.

Note that operators will need to issue ALTER TENANT ALL SET CLUSTER SETTING ... in addition to SET CLUSTER SETTING to effectively change the value for everyone.

@erikgrinaker
Copy link
Copy Markdown
Contributor Author

Thanks for the heads-up.

CI failures are unrelated.

bors r+

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Nov 14, 2022

Build succeeded:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants