Skip to content

roachtest/mixed-versions-compat: use corpus for master#91458

Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom
fqazi:mixedVersionNumber
Jan 20, 2023
Merged

roachtest/mixed-versions-compat: use corpus for master#91458
craig[bot] merged 1 commit intocockroachdb:masterfrom
fqazi:mixedVersionNumber

Conversation

@fqazi
Copy link
Copy Markdown
Collaborator

@fqazi fqazi commented Nov 8, 2022

Informs: #91350

The CI build scripts take advantage of the branch name to uplaod the corpus to GCS. Unfortunately, we have no way of know if the current build is master inside the roachtest. To address this, this patch supports fetching the master corpus as a fallback.

Release note: None

@fqazi fqazi requested a review from a team November 8, 2022 01:09
@cockroach-teamcity
Copy link
Copy Markdown
Member

This change is Reviewable

@fqazi fqazi force-pushed the mixedVersionNumber branch from f73f790 to e707f27 Compare November 8, 2022 03:29
Copy link
Copy Markdown
Contributor

@ajwerner ajwerner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @fqazi)

@fqazi fqazi marked this pull request as ready for review November 8, 2022 15:26
@fqazi
Copy link
Copy Markdown
Collaborator Author

fqazi commented Nov 8, 2022

@ajwerner I'm going to bors this to have the test functional again, but we do have a compatibility issue between master and 22.2 in the mixed version state (which is planning related)

@fqazi
Copy link
Copy Markdown
Collaborator Author

fqazi commented Nov 8, 2022

bors r+

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Nov 8, 2022

Build failed (retrying...):

@fqazi
Copy link
Copy Markdown
Collaborator Author

fqazi commented Nov 8, 2022

bors r-

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Nov 8, 2022

Canceled.

@fqazi fqazi force-pushed the mixedVersionNumber branch from e707f27 to 2c2cbff Compare January 20, 2023 16:14
@fqazi fqazi requested a review from a team as a code owner January 20, 2023 16:14
@fqazi fqazi requested review from renatolabs and smg260 and removed request for a team January 20, 2023 16:14
Fixes: cockroachdb#91350

The CI build scripts take advantage of the branch name
to uplaod the corpus to GCS. Unfortunately, we have
no way of know if the current build is master inside
the roachtest. To address this, this patch supports
fetching the master corpus as a fallback.

Release note: None
@fqazi fqazi force-pushed the mixedVersionNumber branch from 2c2cbff to 137e0c0 Compare January 20, 2023 16:29
@fqazi
Copy link
Copy Markdown
Collaborator Author

fqazi commented Jan 20, 2023

bors r+

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Jan 20, 2023

Build failed (retrying...):

@craig craig bot merged commit 1b79102 into cockroachdb:master Jan 20, 2023
@craig
Copy link
Copy Markdown
Contributor

craig bot commented Jan 20, 2023

Build succeeded:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants