importer: unit test that reproduces delayed AddSSTable application#91407
Closed
stevendanna wants to merge 1 commit intocockroachdb:masterfrom
Closed
importer: unit test that reproduces delayed AddSSTable application#91407stevendanna wants to merge 1 commit intocockroachdb:masterfrom
stevendanna wants to merge 1 commit intocockroachdb:masterfrom
Conversation
Member
|
This change is |
msbutler
reviewed
Nov 7, 2022
|
|
||
| func (idp *readImportDataProcessor) close() { | ||
| if idp.Closed { | ||
| return |
Collaborator
There was a problem hiding this comment.
one question i have for the queries team: does idp.Closed==true imply that the context passed to Start() has been closed? I couldn't understand this easily from poking around processorBase.
msbutler
reviewed
Nov 7, 2022
Collaborator
msbutler
left a comment
There was a problem hiding this comment.
this unit test is :chef-kiss
| @@ -159,46 +157,46 @@ func (tc *TestCluster) stopServers(ctx context.Context) { | |||
| // was passed in at cluster creation time). We should not allow the Tracer to | |||
| // be passed in like this, and we should then also added this registry | |||
| // draining check to individual TestServers. | |||
Collaborator
There was a problem hiding this comment.
did this leak into this pr?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.