sql: fix data race in session serialization#90983
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Oct 31, 2022
Merged
sql: fix data race in session serialization#90983craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
This commit fixes a data race in session serialization that was introduced by ac280a9. Previously, the session serialization code attempted to read the original, parsed AST to create a redacted statement string. This is invalid because the AST is unfortunately not immutable, and serialization can occur concurrently with statement optimization and execution. Now, the session serializer re-parses the original SQL to avoid this issue. Release note: None
Member
|
This change is |
ajwerner
approved these changes
Oct 31, 2022
Contributor
ajwerner
left a comment
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @rafiss)
Member
Author
|
TFTR! bors r+ |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #90965
This commit fixes a data race in session serialization that was introduced by ac280a9.
Previously, the session serialization code attempted to read the original, parsed AST to create a redacted statement string. This is invalid because the AST is unfortunately not immutable, and serialization can occur concurrently with statement optimization and execution.
Now, the session serializer re-parses the original SQL to avoid this issue.
Release note: None