logictest: check for nil SystemConfig before purging zone config cache#90802
logictest: check for nil SystemConfig before purging zone config cache#90802craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Fixes cockroachdb#88398 This fixes a panic which can occur duing cluster startup in a logic test or during retry of a test case in a logic test when an attempt is made to purge the zone config cache and no SystemConfig is available. Release note: None
|
This change is |
yuzefovich
left a comment
There was a problem hiding this comment.
We should also probably backport this to 22.2 (and maybe 22.2.0).
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @cucaroach)
msirek
left a comment
There was a problem hiding this comment.
We should also probably backport this to 22.2 (and maybe 22.2.0).
The root cause, #87391, is not in those releases AFAICT, so no need to backport.
Reviewable status:
|
I see. There is also #89419 which seems like a dup of this PR. |
|
Thanks, made a note in that PR. |
msirek
left a comment
There was a problem hiding this comment.
TFTR!
bors r=yuzefovich
Reviewable status:
|
Build succeeded: |
Fixes #88398
This fixes a panic which can occur duing cluster startup in a logic test or during retry of a test case in a logic test when an attempt is made to purge the zone config cache and no SystemConfig is available.
Release note: None