sqlinstance: get rid of sqlinstance.Provider #90777
Merged
craig[bot] merged 2 commits intocockroachdb:masterfrom Oct 27, 2022
Merged
sqlinstance: get rid of sqlinstance.Provider #90777craig[bot] merged 2 commits intocockroachdb:masterfrom
craig[bot] merged 2 commits intocockroachdb:masterfrom
Conversation
Release note: None
This interface, together with its implementation, were the worst. It combined an AddressResolver with allocating an instance ID, which are two things have very little to do with one another. The implementation also did a 3rd thing - it was remembering the allocated instance ID, seemingly giving this object state, although nobody was benefiting from that. The implementation was also hiding clues about how the instance ID was being created, namely with the help of a session (i.e. a sqlliveness.Instance). This connection between the sqlliveness package and the sqlinstance package was quite hidden (for example it was not apparent in this Provider interface), and it deserves to be more visible. This patch gets rid of both the interface and the implementation, in favor of breaking down the two main parts. The SQLServer now has a instancestorage.Reader and a instancestorage.Storage; these are concrete types, so there's no more interface hell. These fields are nil for single-tenant instead of dummy interface implementations and that seems to be fine, so the need for dummy interfaces was reduced. Release note: None
Member
|
This change is |
ajwerner
approved these changes
Oct 27, 2022
Contributor
ajwerner
left a comment
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, 14 of 14 files at r2, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @aadityasondhi)
Contributor
Author
|
TFTR! bors r+ |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This interface, together with its implementation, were the worst. It
combined an AddressResolver with allocating an instance ID, which are
two things have very little to do with one another. The implementation
also did a 3rd thing - it was remembering the allocated instance ID,
seemingly giving this object state, although nobody was benefiting from
that. The implementation was also hiding clues about how the instance ID
was being created, namely with the help of a session (i.e. a
sqlliveness.Instance). This connection between the sqlliveness package
and the sqlinstance package was quite hidden (for example it was not
apparent in this Provider interface), and it deserves to be more
visible.
This patch gets rid of both the interface and the implementation, in
favor of breaking down the two main parts. The SQLServer now has a
instancestorage.Reader and a instancestorage.Storage; these are concrete
types, so there's no more interface hell. These fields are nil for
single-tenant instead of dummy interface implementations and that seems
to be fine, so the need for dummy interfaces was reduced.
Release note: None
Epic: None