builtins: fix pg_function_is_visible to work with UDFs#90657
Merged
craig[bot] merged 3 commits intocockroachdb:masterfrom Dec 13, 2022
Merged
builtins: fix pg_function_is_visible to work with UDFs#90657craig[bot] merged 3 commits intocockroachdb:masterfrom
craig[bot] merged 3 commits intocockroachdb:masterfrom
Conversation
Member
|
This change is |
262a557 to
7854205
Compare
Release note (bug fix): The pg_function_is_visible function now correctly reports visibility based on the functions that are visible on the current search_path.
f6dad5d to
0f347b4
Compare
This saves us from having to maintain the old code, which I personally found to be a bit hard to work with. Using the internal executor like this should be faster than it used to be, since there is an index on pg_type(oid) that will avoid any lookups for builtin types. Release note: None
Release note: None
0f347b4 to
9d330c7
Compare
e-mbrown
approved these changes
Dec 12, 2022
Contributor
e-mbrown
left a comment
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1, 5 of 5 files at r2, 3 of 3 files at r3, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @rafiss)
Collaborator
Author
|
tftr! bors r=e-mbrown |
Contributor
|
Build failed (retrying...): |
Contributor
|
Build failed (retrying...): |
Collaborator
Author
|
bors r=e-mbrown |
Contributor
|
Already running a review |
Contributor
|
Build failed (retrying...): |
Contributor
|
Build failed: |
Collaborator
Author
|
bors r=e-mbrown |
Contributor
|
Build failed (retrying...): |
Contributor
|
Build failed (retrying...): |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #89546
builtins: fix pg_function_is_visible to work with UDFs
Release note (bug fix): The pg_function_is_visible function now
correctly reports visibility based on the functions that are visible on
the current search_path.
builtins: use pg_type to implement pg_type_is_visible
This saves us from having to maintain the old code, which I personally
found to be a bit hard to work with. Using the internal executor like
this should be faster than it used to be, since there is an index on
pg_type(oid) that will avoid any lookups for builtin types.
sessiondata: consolidate logic for searching the search_path