encoding: make DecodeFloatDescending return same NaN as ascending#90214
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Oct 19, 2022
Merged
encoding: make DecodeFloatDescending return same NaN as ascending#90214craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Member
|
This change is |
DrewKimball
approved these changes
Oct 19, 2022
Collaborator
DrewKimball
left a comment
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @msirek)
msirek
approved these changes
Oct 19, 2022
Contributor
msirek
left a comment
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:
There are multiple representations of NaN in floating point. We were returning a different representation for descending indexes. There are some functions, such as `st_makepointm` that are sensitive to the difference, and this complicates testing. So let's always return the same bitwise representation for NaN. Fixes: cockroachdb#89961 Release note: None
Collaborator
Author
|
Added a test case. TFYRs! bors r=DrewKimball,msirek |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are multiple representations of NaN in floating point. We were returning a different representation for descending indexes. There are some functions, such as
st_makepointmthat are sensitive to the difference, and this complicates testing. So let's always return the same bitwise representation for NaN.Fixes: #89961
Release note: None