ui: add apply recommendations to table details#90070
ui: add apply recommendations to table details#90070craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
|
This change is |
THardy98
left a comment
There was a problem hiding this comment.
Just a quick question: What were your thoughts on using the index as the key considering the potential issues (https://robinpokorny.com/blog/index-as-a-key-is-an-anti-pattern/) When the order of the index recommendations are changed does it render as expected?
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @maryliag)
maryliag
left a comment
There was a problem hiding this comment.
The order works as expected: https://www.loom.com/share/e90d5cd36557496491c119f7828a4367
This case you're mentioning is when we make changes on the UI, by adding/removing elements, but that won't happen on this case. The values are based on the endpoint, and if there is a new recommendation, it will render the page again, not just that small part. We do use the idx as the key on several locations on our codebase.
Reviewable status:
THardy98
left a comment
There was a problem hiding this comment.
Ah, thank you!
Reviewable status:
On Table details page, we have a table with index recommendations, which right now is focused on drop unused indexes. This commit adds the button the apply the recommendations, when there is one. Fixes cockroachdb#86949 Release note (ui change): Add apply button on Table Details page (db console only), when there is a recommendation to drop an unused index.
|
TFTR! |
|
Build succeeded: |
|
blathers backport 22.2 |
|
Encountered an error creating backports. Some common things that can go wrong:
You might need to create your backport manually using the backport tool. error creating merge commit from eb64879 to blathers/backport-release-22.2-90070: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict [] you may need to manually resolve merge conflicts with the backport tool. Backport to branch 22.2 failed. See errors above. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan. |
On Table details page, we have a table with index
recommendations, which right now is focused on drop unused indexes. This commit adds the button the apply the recommendations, when there is one.
Fixes #86949
Release note (ui change): Add apply button on Table Details page (db console only), when there is a recommendation to drop an unused index.