cli: don't output SQL results during zone set#9007
Merged
madelynnblue merged 1 commit intocockroachdb:developfrom Sep 1, 2016
madelynnblue:zone
Merged
cli: don't output SQL results during zone set#9007madelynnblue merged 1 commit intocockroachdb:developfrom madelynnblue:zone
madelynnblue merged 1 commit intocockroachdb:developfrom
madelynnblue:zone
Conversation
Also take the opportunity to use an UPSERT. Fixes #8955
Contributor
|
LGTM |
| err = runQueryAndFormatResults(conn, os.Stdout, | ||
| makeQuery(`INSERT INTO system.zones VALUES ($1, $2)`, id, buf), cliCtx.prettyFmt) | ||
| } | ||
| _, _, _, err = runQuery(conn, makeQuery( |
Contributor
There was a problem hiding this comment.
consider := while you're here
Contributor
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also take the opportunity to use an UPSERT.
Fixes #8955
This change is