sql: remove unnecessary rowsorts from distsql_stats logic tests#90017
Merged
craig[bot] merged 2 commits intocockroachdb:masterfrom Oct 17, 2022
Merged
sql: remove unnecessary rowsorts from distsql_stats logic tests#90017craig[bot] merged 2 commits intocockroachdb:masterfrom
craig[bot] merged 2 commits intocockroachdb:masterfrom
Conversation
In distsql_stats and distsql_automatic_stats logic tests we frequently use queries like the following: ```sql SELECT ... FROM [SHOW STATISTICS FOR TABLE foo] ORDER BY column_names, created DESC ``` These queries have guaranteed order, and do not need the rowsort option. Epic: CRDB-20535 Release note: None
This prevents some spurious rewrites in the distsql_automatic_stats logic test. Epic: CRDB-20535 Release note: None
Member
|
This change is |
mgartner
approved these changes
Oct 17, 2022
Contributor
mgartner
left a comment
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @dt)
Collaborator
Author
|
TFYR! bors r=mgartner |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sql: remove unnecessary rowsorts from distsql_stats logic tests
In distsql_stats and distsql_automatic_stats logic tests we frequently
use queries like the following:
These queries have guaranteed order, and do not need the rowsort option.
Epic: CRDB-20535
Release note: None
sql: bump testlogic --rewrite delay for queries with retry to 2 sec
This prevents some spurious rewrites in the distsql_automatic_stats
logic test.
Epic: CRDB-20535
Release note: None