Reviewed 1 of 1 files at r1, 2 of 2 files at r2.
Review status: all files reviewed at latest revision, 5 unresolved discussions, all commit checks successful.

storage/client_test.go, line 398 [r2] (raw file):

  nodeIndex := int(rep.NodeID) - 1
  if log.V(2) {
      log.Infof(context.TODO(), "SendNext nodeIndex=%d", nodeIndex)

this is test code - feel free to remove the V(2)

storage/stores.go, line 234 [r2] (raw file):

      repDescFound = true
      rangeID = replica.RangeID

can you move this up to where repDesc is assigned? slightly more expected there.

rangeID = replica.RangeID

var err error
repDesc, err = replica.GetReplicaDescriptor()
...

storage/stores.go, line 237 [r2] (raw file):

  }
  if !repDescFound {
      return 0, roachpb.ReplicaDescriptor{}, roachpb.NewRangeNotFoundError(0)

This looks good to me. Can you write a focused test for it?

storage/stores_test.go, line 205 [r1] (raw file):

      if tc.expError != "" {
          if !testutils.IsError(err, tc.expError) {
              t.Errorf("got unexpected error %v", err)

you need to log the expected error here - it is no longer evident from the code. also, every one of these calls to Errorf should begin with the loop index variable "%d: "

Comments from Reviewable

Review status: 0 of 3 files reviewed at latest revision, 5 unresolved discussions, some commit checks pending.

storage/stores.go, line 221 [r2] (raw file):

storage/stores.go, line 234 [r2] (raw file):

storage/stores.go, line 237 [r2] (raw file):

storage/stores_test.go, line 205 [r1] (raw file):

Comments from Reviewable

Reviewed 3 of 3 files at r3, 3 of 3 files at r4.
Review status: all files reviewed at latest revision, 2 unresolved discussions, some commit checks pending.

storage/stores.go, line 223 [r4] (raw file):

      if err != nil {
          if _, ok := err.(*roachpb.RangeNotFoundError); ok {
              // We are not holding a lock across this block so the range could have

"range could have gone away" isn't very descriptive. specifically, this would only happen if this replica was removed from the range via down-replication.

Comments from Reviewable

Reviewed 3 of 3 files at r5, 3 of 3 files at r6.
Review status: all files reviewed at latest revision, 2 unresolved discussions.

Comments from Reviewable

Review status: 2 of 3 files reviewed at latest revision, 2 unresolved discussions, some commit checks pending.

storage/stores.go, line 223 [r4] (raw file):

Comments from Reviewable

Reviewed 2 of 3 files at r6, 1 of 1 files at r7.
Review status: all files reviewed at latest revision, 1 unresolved discussion, some commit checks pending.

Comments from Reviewable