sql: put session events in eventlog#8949
Merged
RaduBerinde merged 1 commit intocockroachdb:developfrom Aug 31, 2016
Merged
Conversation
420556c to
db2c3fe
Compare
Contributor
|
Review status: 0 of 3 files reviewed at latest revision, 2 unresolved discussions, all commit checks successful. sql/session.go, line 100 [r1] (raw file):
nit: "sql.root" didn't look obvious to me that it contained a user name. How about "sql [user]" sql/session.go, line 181 [r1] (raw file):
good riddance Comments from Reviewable |
SQL has a per-session "debug/request" trace which can be very long-lived. Replacing it with an EventLog (which shows up under "debug/events").
db2c3fe to
889aa7c
Compare
Member
Author
|
Review status: 0 of 3 files reviewed at latest revision, 2 unresolved discussions, some commit checks pending. sql/session.go, line 100 [r1] (raw file):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SQL has a per-session "debug/request" trace which can be very long-lived.
Replacing it with an EventLog (which shows up under "debug/events").
This change is