opt: check for nulls before attempting to fold binary operators#89047
opt: check for nulls before attempting to fold binary operators#89047craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
|
This change is |
rytaft
left a comment
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @DrewKimball)
-- commits line 7 at r1:
nit: expecte -> expect
556e73d to
09bccab
Compare
DrewKimball
left a comment
There was a problem hiding this comment.
Reviewable status:
Previously, rytaft (Rebecca Taft) wrote…
nit: expecte -> expect
Done.
rytaft
left a comment
There was a problem hiding this comment.
Reviewed all commit messages.
Reviewable status:
Previously, DrewKimball (Drew Kimball) wrote…
Done.
now you've got a different typo :) expected -> expect
This commit adds a check before the call to `eval.BinaryOp` to ensure that the operands are non-null before attempting to fold a plus or minus expression. This prevents a panic that would occur down the stack due to a type assertion that doesn't expect NULL values. Fixes cockroachdb#89024 Release note: None
09bccab to
51c608a
Compare
DrewKimball
left a comment
There was a problem hiding this comment.
Reviewable status:
Previously, rytaft (Rebecca Taft) wrote…
now you've got a different typo :) expected -> expect
Agh, thanks. Done.
rytaft
left a comment
There was a problem hiding this comment.
Reviewed all commit messages.
Reviewable status:
|
Failures look unrelated. TFTR! bors r+ |
|
Build failed: |
|
bors r+ |
|
Build succeeded: |
|
Thanks for fixing this! |
|
blathers backport 22.2.0 |
|
blathers backport 22.1 21.2 |
|
Encountered an error creating backports. Some common things that can go wrong:
You might need to create your backport manually using the backport tool. error creating merge commit from 51c608a to blathers/backport-release-22.1-89047: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict [] you may need to manually resolve merge conflicts with the backport tool. Backport to branch 22.1 failed. See errors above. error creating merge commit from 51c608a to blathers/backport-release-21.2-89047: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict [] you may need to manually resolve merge conflicts with the backport tool. Backport to branch 21.2 failed. See errors above. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan. |
This commit adds a check before the call to
eval.BinaryOpto ensure that the operands are non-null before attempting to fold a plus or minus expression. This prevents a panic that would occur down the stack due to a type assertion that doesn't expect NULL values.Fixes #89024
Release note: None