Skip to content

contentionutils: further document ConcurrentBufferGuard#88841

Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom
matthewtodd:concurrent-buffer-guard
Sep 29, 2022
Merged

contentionutils: further document ConcurrentBufferGuard#88841
craig[bot] merged 1 commit intocockroachdb:masterfrom
matthewtodd:concurrent-buffer-guard

Conversation

@matthewtodd
Copy link
Copy Markdown

Fixes #83080

Release note: None

@matthewtodd matthewtodd requested review from a team, ajwerner and knz September 27, 2022 18:23
@cockroach-teamcity
Copy link
Copy Markdown
Member

This change is Reviewable

Copy link
Copy Markdown
Contributor

@ajwerner ajwerner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @knz)

@matthewtodd
Copy link
Copy Markdown
Author

bors r+

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Sep 29, 2022

Build succeeded:

@craig craig bot merged commit 4780ee1 into cockroachdb:master Sep 29, 2022
@matthewtodd matthewtodd deleted the concurrent-buffer-guard branch October 5, 2022 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

sql: likely incorrect locking pattern in ConcurrentBufferGuard (contention mgt), possibly leading to rare deadlocks

3 participants