kvserver: use type-safe atomics in raftSendQueue#88800
kvserver: use type-safe atomics in raftSendQueue#88800craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Go 1.19 introduced atomic types that enforce atomic access to variables, which in many situation is less error-prone. This commit resolves a TODO to take advantage of these types. Release note: None
|
This change is |
nvb
left a comment
There was a problem hiding this comment.
In #88506, I mentioned to @arulajmani that leaving our go directive in go.mod set to 1.17 should have prevented use of the new atomic stdlib additions from compiling. I think I misunderstood the go directive. It prevents use of new language features (e.g. generics), but not of library additions (e.g. atomic.Int64).
So this LGTM.
Huh, my previous knowledge of this directive is: it just instructs which |
|
bors r=nvanbenschoten |
|
Build failed (retrying...): |
|
bors retry |
|
Already running a review |
|
Build succeeded: |
Go 1.19 introduced atomic types that enforce atomic access to variables, which in many situation is less error-prone. This commit resolves a TODO to take advantage of these types.
Release note: None