Skip to content

ci: add MacOS ARM CI config#88768

Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom
rail:add-macosarm64-ci
Sep 28, 2022
Merged

ci: add MacOS ARM CI config#88768
craig[bot] merged 1 commit intocockroachdb:masterfrom
rail:add-macosarm64-ci

Conversation

@rail
Copy link
Copy Markdown
Member

@rail rail commented Sep 26, 2022 •
edited
Loading

Previously, MacOS64 ARM64 platform was added, but CI wouldn't run it.

This PR adds a CI platform to build MacOS ARM64 binaries.

Release note: None

@rail
ci: add MacOS ARM CI config
416037f 
Previously, MacOS64 ARM64 platform was added, but CI wouldn't run it.

This PR adds a nes CI platform to build MacOS ARM64 binaries.

Release note: None
@rail rail added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-dev-inf A-ci Continuous Integration labels Sep 26, 2022
@rail rail self-assigned this Sep 26, 2022
@rail rail requested a review from a team as a code owner September 26, 2022 20:34
@cockroach-teamcity
Copy link
Copy Markdown
Member

cockroach-teamcity commented Sep 26, 2022

This change is Reviewable

@rail rail requested a review from jlinder September 26, 2022 20:49
jlinder
jlinder approved these changes Sep 27, 2022
View reviewed changes
Copy link
Copy Markdown
Collaborator

@jlinder jlinder left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Also, can't the release justification line in the PR body be removed? Or did you preemptively put it there for the backport?

@rail
Copy link
Copy Markdown
Member Author

rail commented Sep 27, 2022

Also, can't the release justification line in the PR body be removed? Or did you preemptively put it there for the backport?

Yup. Removed.

@rail
Copy link
Copy Markdown
Member Author

rail commented Sep 27, 2022

bors r=jlinder

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Sep 28, 2022

Build succeeded:

@craig craig bot merged commit cdd8b6e into cockroachdb:master Sep 28, 2022
@blathers-crl blathers-crl bot mentioned this pull request Sep 28, 2022
Merged
@rail rail deleted the add-macosarm64-ci branch March 14, 2025 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jlinder jlinder jlinder approved these changes

Assignees

@rail rail

Labels

A-ci Continuous Integration C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-dev-inf

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rail @cockroach-teamcity @jlinder