kvserver: partial implementation of ReplicasStorage#88606
Closed
sumeerbhola wants to merge 1 commit intocockroachdb:masterfrom
Closed
kvserver: partial implementation of ReplicasStorage#88606sumeerbhola wants to merge 1 commit intocockroachdb:masterfrom
sumeerbhola wants to merge 1 commit intocockroachdb:masterfrom
Conversation
Member
|
This change is |
e5557c6 to
e2e7c10
Compare
Member
|
cc @cockroachdb/replication |
Member
|
Just chatted with @sumeerbhola - we agreed that the Replication team will push this over the finish line. I'm going to close this PR out, since it's annoying for Sumeer to have the work done on a PR that he opened. The PR can still be checked out ( |
Collaborator
Author
|
I have some changes sitting in my local copy that I need to finish and push -- I'm going to do so soon. Is it ok if we delay closing this until someone is actually ready to pick this up -- that allows me to continue pushing changes meanwhile if something occurs to me? |
The significant missing piece is part of the Init implementation to handle a RecoveryInconsistentReplica that requires applying committed raft log entries to the state machine. This missing piece will need to wait until cockroachdb#75729 is fixed. There are multiple TODOs, including related to concurrency, but the implementation is complete enough for the datadriven test to exercise many state transitions. Additionally, the test exercises loss of unsynced state, and fixup of that state in ReplicasStorage.Init, by using vfs.NewStrictMem. Informs cockroachdb#16624 Release note: None
Member
|
Of course! I will hold off on touching this until you confirm that you're ready. |
Collaborator
Author
|
I've pushed my pending changes. |
Member
|
Interesting failure on the PR here, hope this isn't indicative of some storage bug: |
Member
|
Closing for #91579, which is a copy of this PR that doesn't spam Sumeer's inbox. |
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The significant missing piece is part of the Init
implementation to handle a RecoveryInconsistentReplica that requires applying committed raft log entries to the state machine. This missing piece will need to wait until #75729 is fixed.
There are multiple TODOs, including related to concurrency, but the implementation is complete enough for the datadriven test to exercise many state transitions. Additionally, the test exercises loss of unsynced state, and fixup of that state in ReplicasStorage.Init, by using vfs.NewStrictMem.
Informs #16624
Release note: None