xform: make FoldDivOne an essential normalization#88485
xform: make FoldDivOne an essential normalization#88485craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Fixes cockroachdb#86790 This fixes sqlsmith errors caused by differences in the number of displayed digits right of the decimal place for `expression / 1` by making the folding of this expression essential. Release note: None
|
This change is |
DrewKimball
left a comment
There was a problem hiding this comment.
Thanks for doing this!
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @cucaroach and @mgartner)
msirek
left a comment
There was a problem hiding this comment.
Sure. @mgartner Which backport releases do you think are appropriate?
Reviewable status:
msirek
left a comment
There was a problem hiding this comment.
TFTR!
bors r+
Reviewable status:
|
Build succeeded: |
I think 22.2 would be good. |
|
blathers backport release-22.2 |
|
Encountered an error creating backports. Some common things that can go wrong:
You might need to create your backport manually using the backport tool. error creating merge commit from 956948e to blathers/backport-release-22.2-88485: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict [] you may need to manually resolve merge conflicts with the backport tool. Backport to branch release-22.2 failed. See errors above. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan. |
Fixes #86790
This fixes sqlsmith errors caused by differences in the number of
displayed digits right of the decimal place for
expression / 1by making the folding of this expression essential.
Release note: None