Skip to content

cli/sql: increase maxHistEntries#88478

Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom
knz:20220922-hist
Sep 22, 2022
Merged

cli/sql: increase maxHistEntries#88478
craig[bot] merged 1 commit intocockroachdb:masterfrom
knz:20220922-hist

Conversation

@knz
Copy link
Copy Markdown
Contributor

@knz knz commented Sep 22, 2022

As discussed this morning.

In light of PR #88272, we don't need the limit to be as low as 1000. This commit increases it back to 10000, which is the common default in unix shells and the screen/tmux utilities.

In light of PR cockroachdb#88272, we don't need the limit to be as low as 1000.
This commit increases it back to 10000, which is the common default in
unix shells and the screen/tmux utilities.

Release note: None
@knz knz requested review from a team and ajwerner September 22, 2022 17:09
@knz knz requested a review from a team as a code owner September 22, 2022 17:09
@cockroach-teamcity
Copy link
Copy Markdown
Member

This change is Reviewable

Copy link
Copy Markdown
Contributor

@ajwerner ajwerner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @knz)

@knz
Copy link
Copy Markdown
Contributor Author

knz commented Sep 22, 2022

bors r=ajwerner

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Sep 22, 2022

Build succeeded:

@craig craig bot merged commit d390148 into cockroachdb:master Sep 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants