ui: add connected components for insights#88419
ui: add connected components for insights#88419craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
|
This change is |
aa7f92c to
b05415f
Compare
|
FYI, the statement fingerprint details pages are returning an undefined error: Loom: https://www.loom.com/share/09deb18b98044502a7f41320081f7c8e |
This commit adds connected components for the workload and schema insights pages, for use in the CC Console. Fixes cockroachdb#87693. Release note: None
b05415f to
15e8355
Compare
maryliag
left a comment
There was a problem hiding this comment.
when do you see this error? is just on the browser when you open the details page or it doesn't even load the page?
Reviewed 35 of 37 files at r1.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @ericharmeling and @maryliag)
pkg/ui/workspaces/cluster-ui/src/store/sagas.ts line 40 at r1 (raw file):
fork(transactionInsightsSaga), fork(transactionInsightDetailsSaga), fork(statementInsightsSaga),
to confirm: there is no statementInsightsDetailsSaga because we don't do a call for the details here like we do on the transactions, right?
ericharmeling
left a comment
There was a problem hiding this comment.
Reviewable status:
pkg/ui/workspaces/cluster-ui/src/store/sagas.ts line 40 at r1 (raw file):
Previously, maryliag (Marylia Gutierrez) wrote…
to confirm: there is no statementInsightsDetailsSaga because we don't do a call for the details here like we do on the transactions, right?
Yes! Exactly.
maryliag
left a comment
There was a problem hiding this comment.
With the error on the SQL Activity aside, the changes made here to make it available on CC Console Dedicated:
Reviewed 2 of 37 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status:
ericharmeling
left a comment
There was a problem hiding this comment.
TFTR!
Reviewable status:
|
bors r+ |
|
Build succeeded: |
Following up on this error: It does not affect DB Console, and it does not occur in the commits before this PR. To reproduce: (from (from Navigate to localhost:8081 -> sql-obs-latest -> SQL Activity -> select any statement fingerprint
|
This commit adds connected components for the workload and schema insights pages, for use in the CC Console.
Fixes #87693.
https://www.loom.com/share/08163a7c125948119ca71ac097099a29
Release note: None