stats: make recent fix more conservative#88300
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Sep 20, 2022
Merged
Conversation
We recently merged a fix for histograms of INT2 and INT4 types to not exceed their range, and we used an exact equality against the boundary values when determining whether "outer" buckets are needed. This commit makes that logic more bullet-proof by using an inequality. The sampled values that exceed the supported ranges for the types should not really happen, but let's be conservative. Release note: None
Member
|
This change is |
rytaft
approved these changes
Sep 20, 2022
Collaborator
rytaft
left a comment
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @michae2)
michae2
approved these changes
Sep 20, 2022
Collaborator
michae2
left a comment
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:
Member
Author
|
TFTRs! bors r+ |
Contributor
|
Build failed (retrying...): |
Contributor
|
Build succeeded: |
This was referenced Sep 21, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We recently merged a fix for histograms of INT2 and INT4 types to not exceed their range, and we used an exact equality against the boundary values when determining whether "outer" buckets are needed. This commit makes that logic more bullet-proof by using an inequality. The sampled values that exceed the supported ranges for the types should not really happen, but let's be conservative.
Release note: None