Skip to content

stats: fix recent flake in tests#88261

Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom
yuzefovich:fix-stats-flake
Sep 20, 2022
Merged

stats: fix recent flake in tests#88261
craig[bot] merged 1 commit intocockroachdb:masterfrom
yuzefovich:fix-stats-flake

Conversation

@yuzefovich
Copy link
Copy Markdown
Member

We recently hard-coded the type of the datum as INT in a test, but we actually might be using FLOAT there.

Fixes: #88249.

Release note: None

We recently hard-coded the type of the datum as INT in a test, but we
actually might be using FLOAT there.

Release note: None
@yuzefovich yuzefovich requested review from a team and michae2 September 20, 2022 16:49
@cockroach-teamcity
Copy link
Copy Markdown
Member

This change is Reviewable

Copy link
Copy Markdown
Collaborator

@michae2 michae2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm: ah yeah

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @yuzefovich)

@yuzefovich
Copy link
Copy Markdown
Member Author

TFTR!

bors r+

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Sep 20, 2022

Build failed (retrying...):

@knz
Copy link
Copy Markdown
Contributor

knz commented Sep 20, 2022

bors p=99 retry

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Sep 20, 2022

Build succeeded:

@craig craig bot merged commit f7f7466 into cockroachdb:master Sep 20, 2022
@yuzefovich yuzefovich deleted the fix-stats-flake branch September 20, 2022 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

sql/stats: TestAdjustCounts is flakey

4 participants