cdc: fix assignment to nil map panic in json encoder#88241
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Sep 20, 2022
Merged
cdc: fix assignment to nil map panic in json encoder#88241craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Member
|
This change is |
Contributor
Author
|
This is probably not necessary if #88064 is merged. |
miretskiy
approved these changes
Sep 20, 2022
JSON encoding a delete message for a deleted row was panicking. This fixes that. Release note (bug fix): Fixed a crash in changefeed expressions when JSON encoding an empty projection.
cdf0dbf to
2fb46bf
Compare
Contributor
Author
|
bors r=[miretskiy] |
Contributor
|
Build failed (retrying...): |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JSON encoding a delete message for a deleted row was panicking. This fixes that.
Release note (bug fix): Fixed a crash in changefeed expressions when JSON encoding an empty projection.