sql: pg_proc should respect context db for udf#88167
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Sep 20, 2022
Merged
sql: pg_proc should respect context db for udf#88167craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Member
|
This change is |
`pg_proc` table should only return udf in the context db if it's not nil. Release note: None Release justification: low risk virtual table improvement.
b8b7773 to
9edd63b
Compare
rafiss
approved these changes
Sep 19, 2022
Collaborator
rafiss
left a comment
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @chengxiong-ruan)
Contributor
Author
|
TFTR! |
Contributor
|
Build failed (retrying...): |
Contributor
Author
|
looks like flaky tests.. |
Contributor
|
Already running a review |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pg_proctable should only return udf in the context db if it's not nil.Release note: None
Release justification: low risk virtual table improvement.