kvevent: Fix bookkeeping related to out of quota handling#87997
kvevent: Fix bookkeeping related to out of quota handling#87997craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
|
This change is |
da48640 to
5e60936
Compare
HonoreDB
left a comment
There was a problem hiding this comment.
Reviewed 1 of 4 files at r1.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @ajwerner, @jayshrivastava, and @miretskiy)
pkg/ccl/changefeedccl/kvevent/blocking_buffer.go line 181 at r1 (raw file):
} if b.mu.numBlocked == 0 { b.mu.canFlush = false
Can you say more about why canFlush is set to false here? (Would needFlush be a more accurate name?)
Done; And no, I think canFlush is more accurate than needFlush. The fact that we are blocked doesn't mean |
a9bbc8f to
7962533
Compare
Fix a bug in blocking buffer bookkeeping which could cause an out of quota event to not be delivered when there is a single consumer. In addition, fix a bug where FlushEvents were counted toward quota. This was wrong since FlushEvents are meant to signal that we are out of quota, and blocking to acquire more quota for those events is wrong. This issue was manifested by `TestChangefeedFlushesSinkToReleaseMemory` test taking excessive long time. Fixes cockroachdb#87828 Release note: None Release justification: bug fix
HonoreDB
left a comment
There was a problem hiding this comment.
Reviewable status:
|
bors r+ |
|
Build succeeded: |
|
Encountered an error creating backports. Some common things that can go wrong:
You might need to create your backport manually using the backport tool. error creating merge commit from 39055e6 to blathers/backport-release-22.1-87997: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict [] you may need to manually resolve merge conflicts with the backport tool. Backport to branch 22.1.x failed. See errors above. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan. |
Fix a bug in blocking buffer bookkeeping which could cause an out of quota event to not be delivered when there is a single consumer.
Fixes #87828
Release note: None
Release justification: bug fix