Skip to content

roachtest: increase slowness threshold in streamer subtest#87821

Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom
yuzefovich:tpchvec
Sep 12, 2022
Merged

roachtest: increase slowness threshold in streamer subtest#87821
craig[bot] merged 1 commit intocockroachdb:masterfrom
yuzefovich:tpchvec

Conversation

@yuzefovich
Copy link
Copy Markdown
Member

This commit bumps up the slowness threshold for the streamer subtest from 1.25 to 1.5 in order to eliminate rare flakes on Q1 (which doesn't use the streamer at all). 1.5 threshold should still be sufficient as a sanity check (that the streamer doesn't become extremely slow).

Fixes: #87791.

Release note: None

This commit bumps up the slowness threshold for the `streamer` subtest
from 1.25 to 1.5 in order to eliminate rare flakes on Q1 (which doesn't
use the streamer at all). 1.5 threshold should still be sufficient as
a sanity check (that the streamer doesn't become extremely slow).

Release note: None
@yuzefovich yuzefovich requested review from a team, DrewKimball and michae2 September 12, 2022 13:44
@cockroach-teamcity
Copy link
Copy Markdown
Member

This change is Reviewable

Copy link
Copy Markdown
Contributor

@mgartner mgartner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @DrewKimball and @michae2)

@yuzefovich
Copy link
Copy Markdown
Member Author

TFTR!

bors r+

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Sep 12, 2022

Build failed:

@yuzefovich
Copy link
Copy Markdown
Member Author

bors r+

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Sep 12, 2022

Build succeeded:

@craig craig bot merged commit 3b95d11 into cockroachdb:master Sep 12, 2022
@yuzefovich yuzefovich deleted the tpchvec branch September 12, 2022 19:48
@yuzefovich
Copy link
Copy Markdown
Member Author

blathers backport 22.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

roachtest: tpchvec/streamer failed

3 participants