Skip to content

sql: add schema_name to index usage stat telemetry, add descriptions to proto fields#87504

Merged
craig[bot] merged 2 commits intocockroachdb:masterfrom
ericharmeling:idx-usage-schema-name
Sep 7, 2022
Merged

sql: add schema_name to index usage stat telemetry, add descriptions to proto fields#87504
craig[bot] merged 2 commits intocockroachdb:masterfrom
ericharmeling:idx-usage-schema-name

Conversation

@ericharmeling
Copy link
Copy Markdown

@ericharmeling ericharmeling commented Sep 7, 2022

The first commit in this PR adds descriptions to the index usage telemetry
proto fields.

Fixes #85855.

Release justification: non-production code changes
Release note: None

The second commit in this PR adds the schema name to the index usage statistics
telemetry.

Fixes #85932.

Release justification: low risk, high benefit changes to existing functionality
Release note (sql change): Added the schema name to index usage statistics
telemetry.

Eric Harmeling added 2 commits September 7, 2022 11:48
sql: add descriptions to idx usage telemetry fields
b224354 
This commit adds descriptions to the index usage telemetry
proto fields.

Fixes cockroachdb#85855.

Release justification: non-production code changes
Release note: None
sql: add schema_name to index usage stat telemetry
d6dfded 
This commit adds the schema name to the index usage statistics
telemetry.

Fixes cockroachdb#85932.

Release justification: low risk, high benefit changes to existing functionality
Release note (sql change): Added the schema name to index usage statistics
telemetry.
@cockroach-teamcity
Copy link
Copy Markdown
Member

cockroach-teamcity commented Sep 7, 2022

This change is Reviewable

@ericharmeling ericharmeling mentioned this pull request Sep 7, 2022
Closed
@ericharmeling ericharmeling requested a review from a team September 7, 2022 16:25
@ericharmeling ericharmeling marked this pull request as ready for review September 7, 2022 16:37
@ericharmeling ericharmeling requested a review from a team September 7, 2022 16:37
maryliag
maryliag approved these changes Sep 7, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@maryliag maryliag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1, 4 of 4 files at r2, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @ericharmeling)

@ericharmeling
Copy link
Copy Markdown
Author

ericharmeling commented Sep 7, 2022

TFTR!

@ericharmeling
Copy link
Copy Markdown
Author

ericharmeling commented Sep 7, 2022

bors r+

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Sep 7, 2022

Build succeeded:

@craig craig bot merged commit 76a5f63 into cockroachdb:master Sep 7, 2022
@cockroach-teamcity cockroach-teamcity mentioned this pull request Sep 7, 2022
Closed
@maryliag
Copy link
Copy Markdown
Contributor

maryliag commented Sep 8, 2022

@ericharmeling can you backport this to 22.1?

@ericharmeling
Copy link
Copy Markdown
Author

ericharmeling commented Sep 8, 2022

blathers backport 22.2

@blathers-crl
Copy link
Copy Markdown

blathers-crl bot commented Sep 8, 2022

Encountered an error creating backports. Some common things that can go wrong:

  1. The backport branch might have already existed.
  2. There was a merge conflict.
  3. The backport branch contained merge commits.

You might need to create your backport manually using the backport tool.

error creating merge commit from b224354 to blathers/backport-release-22.2-87504: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch 22.2 failed. See errors above.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan.

@ericharmeling
Copy link
Copy Markdown
Author

ericharmeling commented Sep 8, 2022

blathers backport 22.1

@blathers-crl
Copy link
Copy Markdown

blathers-crl bot commented Sep 8, 2022

Encountered an error creating backports. Some common things that can go wrong:

  1. The backport branch might have already existed.
  2. There was a merge conflict.
  3. The backport branch contained merge commits.

You might need to create your backport manually using the backport tool.

error creating merge commit from b224354 to blathers/backport-release-22.1-87504: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch 22.1 failed. See errors above.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan.

@ericharmeling ericharmeling mentioned this pull request Sep 8, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@maryliag maryliag maryliag approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add schema_name to the index usage statistics telemetry log Missing field descriptions for captured_index_usage_stats event

3 participants

@ericharmeling @cockroach-teamcity @maryliag