Skip to content

sql: add created_at to index usage stat telemetry#87448

Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom
ericharmeling:idx-usage-create-date
Sep 7, 2022
Merged

sql: add created_at to index usage stat telemetry#87448
craig[bot] merged 1 commit intocockroachdb:masterfrom
ericharmeling:idx-usage-create-date

Conversation

@ericharmeling
Copy link
Copy Markdown

@ericharmeling ericharmeling commented Sep 6, 2022

This commit adds a creation timestamp to the index usage
statistics telemetry.

Fixes #84458.

Release justification: low-risk updates to new functionality
Release note(sql change): Added the creation timestamp to index usage statistics
telemetry.

@cockroach-teamcity
Copy link
Copy Markdown
Member

This change is Reviewable

This commit adds a creation timestamp to the index usage
statistics telemetry.

Fixes cockroachdb#84458.

Release justification: low-risk updates to new functionality
Release note(sql change): Added a creation timestamp to index usage statistics
telemetry.
@ericharmeling ericharmeling marked this pull request as ready for review September 7, 2022 13:25
@ericharmeling ericharmeling requested review from a team and THardy98 and removed request for a team and THardy98 September 7, 2022 13:25
@kevin-v-ngo
Copy link
Copy Markdown

Thanks for the quick fix Eric!

FYI @pransudash

Copy link
Copy Markdown
Contributor

@maryliag maryliag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @ericharmeling)

@ericharmeling
Copy link
Copy Markdown
Author

bors r+

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Sep 7, 2022

Build succeeded:

@craig craig bot merged commit d68046c into cockroachdb:master Sep 7, 2022
@maryliag
Copy link
Copy Markdown
Contributor

maryliag commented Sep 8, 2022

@ericharmeling can you backport this to 22.1?

@ericharmeling
Copy link
Copy Markdown
Author

blathers backport 22.1

@blathers-crl
Copy link
Copy Markdown

blathers-crl bot commented Sep 8, 2022

Encountered an error creating backports. Some common things that can go wrong:

  1. The backport branch might have already existed.
  2. There was a merge conflict.
  3. The backport branch contained merge commits.

You might need to create your backport manually using the backport tool.


error creating merge commit from 2f1db38 to blathers/backport-release-22.1-87448: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch 22.1 failed. See errors above.


🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add create_date to our index usage statistics telmetry

4 participants