sql/importer: add hints on null value import failure for CSV files#87443
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Sep 7, 2022
Merged
sql/importer: add hints on null value import failure for CSV files#87443craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Member
|
This change is |
5a569b3 to
fccee16
Compare
fccee16 to
ea76a7c
Compare
ZhouXing19
reviewed
Sep 7, 2022
Collaborator
|
Nice work, LGTM! Just added a nit. |
This patch adds hints notifying the user when an `IMPORT INTO ... CSV DATA` command fails due to null values in the CSV file having leading or trailing whitespace or being quoted when the `allow_quoted_null` option is not set. Fixes cockroachdb#83723 Release justification: low risk, high benefit changes to existing functionality Release note (sql change): A hint will now be provided when importing from a CSV file fails due to null values having leading or trailing whitespace or being quoted when the `allow_quoted_null` option is not set.
ea76a7c to
b358558
Compare
rafiss
approved these changes
Sep 7, 2022
Collaborator
rafiss
left a comment
There was a problem hiding this comment.
nice work
Reviewed 1 of 2 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @msbutler and @ZhouXing19)
ZhouXing19
approved these changes
Sep 7, 2022
Collaborator
Author
|
TFTR! bors r=rafiss,ZhouXing19 |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch adds hints notifying the user when an
IMPORT INTO ... CSV DATAcommand fails due to null values in the CSV file having leading or trailing
whitespace or being quoted when the
allow_quoted_nulloption is not set.Fixes #83723
Release justification: low risk, high benefit changes to existing functionality
Release note (sql change): A hint is now provided when importing from a CSV file fails because a null value has leading or trailing whitespace or because a value is quoted when the
allow_quoted_nulloption is not set.