storage: fix leaked iterators in unit tests#87229
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Aug 31, 2022
Merged
storage: fix leaked iterators in unit tests#87229craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Fix a couple instances of leaked iterators in unit tests in the storage package. This should also resolve the goroutine leak observed in cockroachdb#86256. Informs cockroachdb#71481. Release justification: Non-production code changes Release note: None
Member
|
This change is |
erikgrinaker
approved these changes
Aug 31, 2022
Contributor
erikgrinaker
left a comment
There was a problem hiding this comment.
Oh, my bad, thanks for tracking this down. How would I go about detecting this?
jbowens
commented
Aug 31, 2022
Contributor
Author
jbowens
left a comment
There was a problem hiding this comment.
TFTR!
There's really no good way right now other than changing this to panic on a non-nil error:
cockroach/pkg/storage/pebble.go
Line 1041 in 121ead5
I'm going to take a stab at doing that in #87232.
Reviewable status:
complete! 0 of 0 LGTMs obtained
Contributor
Author
|
bors r=erikgrinaker |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix a couple instances of leaked iterators in unit tests in the storage
package.
This should also resolve the goroutine leak observed in #86256.
Informs #71481.
Release justification: Non-production code changes
Release note: None