ui: make the warning about performance more prominent#87185
ui: make the warning about performance more prominent#87185craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Previously the warning about schema changes affecting performance was too discrete. This commit adds a warning component, so the message is more prominent and the user can see more easily. Release justification: low risk change, improve UX Release note (ui change): Add warning about performance being affected when executing an index recommendation.
|
This change is |
|
How long does it take to apply an index change? Just wondering if there should be text warning the user it could take hours depending on the size of the table. |
j82w
left a comment
There was a problem hiding this comment.
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @kevin-v-ngo and @maryliag)
pkg/ui/workspaces/cluster-ui/src/insights/indexActionBtn.tsx line 142 at r1 (raw file):
intent="warning" className={cx("alert-area")} title={`Schema changes consume additional
Should there also be a warning that adding indexes could impact create time?
maryliag
left a comment
There was a problem hiding this comment.
Reviewable status:
pkg/ui/workspaces/cluster-ui/src/insights/indexActionBtn.tsx line 142 at r1 (raw file):
Previously, j82w wrote…
Should there also be a warning that adding indexes could impact create time?
On the link pointed here there is all this information and extra warnings. There are a lot of warning, so not sure if make sense to add all of them. so we went with the general warning and they can look into the documentation for more.
WDYT @kevin-v-ngo ?
xinhaoz
left a comment
There was a problem hiding this comment.
Reviewed all commit messages.
Reviewable status:
maryliag
left a comment
There was a problem hiding this comment.
Reviewable status:
pkg/ui/workspaces/cluster-ui/src/insights/indexActionBtn.tsx line 142 at r1 (raw file):
Previously, maryliag (Marylia Gutierrez) wrote…
On the link pointed here there is all this information and extra warnings. There are a lot of warning, so not sure if make sense to add all of them. so we went with the general warning and they can look into the documentation for more.
WDYT @kevin-v-ngo ?
discussed offline, we will leave the message as is (at least for now)
|
bors r+ |
|
Build failed (retrying...): |
|
Build succeeded: |
Previously the warning about schema changes affecting
performance was too discrete. This commit adds a warning
component, so the message is more prominent and the user
can see more easily.
Release justification: low risk change, improve UX
Release note (ui change): Add warning about
performance being affected when executing an index
recommendation.