build: remove newly-added node_modules/ trees in ui-maintainer-clean#87135
Merged
craig[bot] merged 2 commits intocockroachdb:masterfrom Aug 31, 2022
Merged
build: remove newly-added node_modules/ trees in ui-maintainer-clean#87135craig[bot] merged 2 commits intocockroachdb:masterfrom
craig[bot] merged 2 commits intocockroachdb:masterfrom
Conversation
A few recent features [1, 2] introduced new node_modules/ trees for dependencies, but didn't update the ui-maintainer-clean Make target to remove them. This allowed those directories to leak between TeamCity builds with Docker user permissions, preventing a `yarn install` in those packages from properly laying out a `node_modules/.bin` directory for executables like `tsc`. Remove the recently-introduced `node_modules/` directories as part of `make ui-maintainer-clean`, to restore a clean state between jobs. [1] d28c072 (ui: add eslint-plugin-crdb package with custom eslint rules, 2022-05-27) [2] c58279d (ui: reintroduce end-to-end UI tests with cypress, 2022-08-12) Release note: None
Gazelle previously searched a few node_modules/ directories to no benefit, since it currently doesn't support generation of tasks from JavaScript sources. Ignore more node_modules/ directories. Release note: None
Member
|
This change is |
rickystewart
approved these changes
Aug 31, 2022
Contributor
Author
|
bors r=rickystewart |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A few recent features [1, 2] introduced new node_modules/ trees for
dependencies, but didn't update the ui-maintainer-clean Make target to
remove them. This allowed those directories to leak between TeamCity
builds with Docker user permissions, preventing a
yarn installinthose packages from properly laying out a
node_modules/.bindirectoryfor executables like
tsc. Remove the recently-introducednode_modules/directories as part ofmake ui-maintainer-clean, torestore a clean state between jobs.
[1] d28c072 (ui: add eslint-plugin-crdb package with custom eslint rules, 2022-05-27)
[2] c58279d (ui: reintroduce end-to-end UI tests with cypress, 2022-08-12)
Release justification: Non-production code changes