ui: fixes to high contention copy in insight workload pages#87110
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Aug 31, 2022
Merged
ui: fixes to high contention copy in insight workload pages#87110craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Member
|
This change is |
maryliag
approved these changes
Aug 30, 2022
Contributor
maryliag
left a comment
There was a problem hiding this comment.
Nice!
Reviewed 9 of 9 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @ericharmeling)
Previously, the High Contention insight type was labeled "High Contention Time", the waiting transactions list was labeled in the incorrect tense, and the details/tooltip description was not properly handling undefined thresholds. This commit fixes those typos. Release justification: bug fix Release note: None
1be9436 to
0e40379
Compare
Author
|
TFTR! FYI, I noticed a couple things:
|
|
How about we rename to |
Author
Would love to. I'll DM you. |
matthewtodd
approved these changes
Aug 31, 2022
Author
|
bors r+ |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the High Contention insight type was labeled
"High Contention Time", and the waiting transactions list
was labeled in the incorrect tense. This commit fixes those
typos.
Release justification: bug fix
Release note: None