pgwire: fix txn options for prepared BEGIN #87047
Merged
craig[bot] merged 2 commits intocockroachdb:masterfrom Aug 30, 2022
Merged
pgwire: fix txn options for prepared BEGIN #87047craig[bot] merged 2 commits intocockroachdb:masterfrom
craig[bot] merged 2 commits intocockroachdb:masterfrom
Conversation
Release note (bug fix): The statement tag for SHOW command results in the pgwire protocol no longer contain the number of returned rows. Release justification: low risk bug fix
Member
|
This change is |
ZhouXing19
reviewed
Aug 29, 2022
| {"Type":"ReadyForQuery","TxStatus":"I"} | ||
|
|
||
| until noncrdb_only | ||
| until |
Collaborator
There was a problem hiding this comment.
Just curious why we are no longer going to return the row number with SHOW now, is it just to be consistent with postgres's behavior?
Collaborator
Author
There was a problem hiding this comment.
yeah, that was the reason
0e62147 to
c35ae78
Compare
ZhouXing19
reviewed
Aug 29, 2022
|
|
||
| until ignore=RowDescription | ||
| ReadyForQuery | ||
| ReadyForQuery |
Collaborator
There was a problem hiding this comment.
Do you think we should add BEGIN AS OF SYSTEM TIME test in batch_stmt too? I see it in implicit_txn but not here. Any particular reason for that?
Collaborator
Author
There was a problem hiding this comment.
hm, let me see if that can be done. i didn't do it initially, since the AS OF SYSTEM TIME can't change after the txn has performed reads/writes
Release note (bug fix): Fixed a bug where the options given to the BEGIN TRANSACTION command would be ignored if the BEGIN was a prepared statement. Release justification: low risk bug fix.
c35ae78 to
d6009e3
Compare
Collaborator
Author
|
tftr! bors r=ZhouXing19 |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #87012
Release note (bug fix): The statement tag for SHOW command
results in the pgwire protocol no longer contain the number of returned
rows.
Release note (bug fix): Fixed a bug where the options given to the BEGIN
TRANSACTION command would be ignored if the BEGIN was a prepared
statement.
Release justification: low risk bug fix