sql: fix TestTelemetryLogging test#87028
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Aug 29, 2022
Merged
Conversation
Member
|
This change is |
a074cd9 to
08f6162
Compare
Resolves: cockroachdb#86118 Previously, the `TestTelemetryLogging` test was failing due to a change causing traced statements to always be sampled. This in turn caused a discrepancy with the number of skipped queries we were expecting in tests. This change fixes this bug by stubbing the tracing status of the test case, allowing predictable numbers of skipped queries. Release justification: bug fixes and low-risk updates to new functionality Release note: None
08f6162 to
45170a9
Compare
matthewtodd
approved these changes
Aug 29, 2022
Author
|
TYFR :) |
Author
|
bors r+ |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #86118
Previously, the
TestTelemetryLoggingtest was failing due to a changecausing traced statements to always be sampled. This in turn caused a
discrepancy with the number of skipped queries we were expecting in
tests. This change fixes this bug by stubbing the tracing status of the
test case, allowing predictable numbers of skipped queries.
Release justification: bug fixes and low-risk updates to new
functionality
Release note: None