Skip to content

roachtest: fix unintended exit when --cockroach-short is passed#86956

Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom
srosenberg:sr/roachtest_main_typo_fix
Aug 26, 2022
Merged

roachtest: fix unintended exit when --cockroach-short is passed#86956
craig[bot] merged 1 commit intocockroachdb:masterfrom
srosenberg:sr/roachtest_main_typo_fix

Conversation

@srosenberg
Copy link
Copy Markdown
Member

Fixes a regression introduced by
#86625.

Release justification: fix roachtest nightly (on master)
Release note: None

Fixes a regression introduced by
cockroachdb#86625.

Release justification: fix roachtest nightly (on master)
Release note: None
@srosenberg srosenberg requested a review from a team as a code owner August 26, 2022 18:20
@srosenberg srosenberg requested review from smg260 and removed request for a team August 26, 2022 18:20
@cockroach-teamcity
Copy link
Copy Markdown
Member

This change is Reviewable

Copy link
Copy Markdown
Member

@yuzefovich yuzefovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, thanks for the catch! :lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @celiala and @smg260)

Copy link
Copy Markdown
Collaborator

@celiala celiala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch - LGTM!

@srosenberg
Copy link
Copy Markdown
Member Author

bors r+

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Aug 26, 2022

Build failed (retrying...):

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Aug 26, 2022

Build succeeded:

@craig craig bot merged commit 8e3b269 into cockroachdb:master Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants