sql: fix cluster_execution_insights priority level#86901
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Aug 26, 2022
j82w:insights/priority
Merged
sql: fix cluster_execution_insights priority level#86901craig[bot] merged 1 commit intocockroachdb:masterfrom j82w:insights/priority
craig[bot] merged 1 commit intocockroachdb:masterfrom
j82w:insights/priority
Conversation
Member
|
This change is |
matthewtodd
approved these changes
Aug 25, 2022
matthewtodd
left a comment
There was a problem hiding this comment.
Cool! I didn't realize these were always surfaced as strings. Thank you!
maryliag
approved these changes
Aug 25, 2022
closes #86900, closes #86867 Release justification: Category 2: Bug fixes and low-risk updates to new functionality Release note (sql change): Fix the insight execution priority to have correct value instead of always being default. Changed the column to be a string to avoid converting it in the ui.
Contributor
Author
|
bors r+ |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the priority level and converts it to be a string.
closes: #86900, closes #86867
Release justification: Category 2: Bug fixes and
low-risk updates to new functionality
Release note (sql change): Fix the insight
execution priority to have correct value
instead of always being default. Changed
the column to be a string to avoid
converting it in the ui.