kv: Include error information in crdb_internal.active_range_feeds#86876
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Aug 26, 2022
Merged
kv: Include error information in crdb_internal.active_range_feeds#86876craig[bot] merged 1 commit intocockroachdb:masterfrom
crdb_internal.active_range_feeds#86876craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Member
|
This change is |
Contributor
Author
|
Example with synthetically injected error:
|
tbg
requested changes
Aug 25, 2022
| defer a.Unlock() | ||
| a.LastErr = errors.Wrapf(err, "disconnect at %s: checkpoint %s/-%s", | ||
| timeutil.Now().Format(time.RFC3339), a.Resolved, timeutil.Since(a.Resolved.GoTime())) | ||
| a.NumErrs++ |
Member
There was a problem hiding this comment.
(Not suggesting you add one here but it would probably be useful?)
Contributor
Author
There was a problem hiding this comment.
Yeah; it would be useful; not going to add it now because I think we need to add per-error type metrics instead. This can happen as a follow in PR
tbg
approved these changes
Aug 25, 2022
aa27167 to
fa0aa95
Compare
Include error count, and the last error information in `crdb_internal.active_range_feeds` table whenever rangefeed disconnects due to an error. Release justification: observability improvement. Release note: None
Contributor
Author
|
bors r+ |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Include error count, and the last error information in
crdb_internal.active_range_feedstable whenever rangefeeddisconnects due to an error.
Release justification: observability improvement.
Release note: None