sql/opt: add session setting to disable stats forecast use in optimizer#86834
sql/opt: add session setting to disable stats forecast use in optimizer#86834craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
|
This change is |
|
Note that the first two commits are #86634 and can be ignored. |
ca36067 to
67f9187
Compare
rytaft
left a comment
There was a problem hiding this comment.
Reviewed 16 of 16 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @cucaroach, @mgartner, and @michae2)
pkg/sql/logictest/testdata/logic_test/crdb_internal line 788 at r1 (raw file):
# Ensure that there are no longer any splits left over on the original indexes. # TRUNCATE will have created equivalent splits points on the new indexes, so # this test just checks that there are no more on the old indexes.
Does this comment need an update?
cc456c9 to
4b2b1a2
Compare
michae2
left a comment
There was a problem hiding this comment.
TFTR!
bors r=rytaft
Reviewable status:
pkg/sql/logictest/testdata/logic_test/crdb_internal line 788 at r1 (raw file):
Previously, rytaft (Rebecca Taft) wrote…
Does this comment need an update?
Ah, this snuck in from a ./dev testlogic --config=local --rewrite. I've reverted it. (I think the retry hides the flakiness?)
|
Build failed (retrying...): |
|
Build failed (retrying...): |
|
Build failed: |
Add a new session setting, `optimizer_use_forecasts`, which can be used to disable forecast usage in the optimizer. Forecasts will still be generated in the stats cache (this will be controlled by a different setting). Assists: cockroachdb#86350 Release justification: Low-risk update to new functionality. Release note (sql change): This commit adds a new session setting, `optimizer_use_forecasts`, which can be set to false to disable usage of statistics forecasts when optimizing a query.
4b2b1a2 to
3eea6fa
Compare
|
"Cannot find commit" hmm. Let's try this again with a rebase. bors r=rytaft |
|
Build failed (retrying...): |
|
Build failed (retrying...): |
|
Build succeeded: |
Add a new session setting,
optimizer_use_forecasts, which can be usedto disable forecast usage in the optimizer. Forecasts will still be
generated in the stats cache (this will be controlled by a different
setting).
Assists: #86350
Release justification: Low-risk update to new functionality.
Release note (sql change): This commit adds a new session setting,
optimizer_use_forecasts, which can be set to false to disable usage ofstatistics forecasts when optimizing a query.