workload/ycsb: fix --request-distribution flag#86826
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Aug 30, 2022
Merged
workload/ycsb: fix --request-distribution flag#86826craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Member
|
This change is |
aayushshah15
approved these changes
Aug 24, 2022
arulajmani
approved these changes
Aug 25, 2022
96d37fc to
aa7e619
Compare
Contributor
Author
|
TFTRs! bors r+ |
Contributor
|
Build failed: |
This change fixes the handling of the --request-distribution flag so that any user overrides are respected. Before, the default request distribution for a given workload was always used, regardless of the flag. This bug dates back to cockroachdb#37804. I fear this has caused a good deal of confusion in the past, as we often turn to YCSB-A uniform as an example of an uncontended read/update workload. Release justification: workload only.
aa7e619 to
519ab83
Compare
Contributor
Author
|
bors r+ |
Contributor
|
Build failed (retrying...): |
Contributor
|
Build succeeded: |
This was referenced Aug 30, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change fixes the handling of the
--request-distributionflag sothat any user overrides are respected. Before, the default request
distribution for a given workload was always used, regardless of the
flag.
This bug dates back to #37804. I fear this has caused a good deal of
confusion in the past, as we often turn to YCSB-A uniform as an example
of an uncontended read/update workload.
Release justification: workload only.