sql/schemachanger: version gate element creation#86774
sql/schemachanger: version gate element creation#86774craig[bot] merged 2 commits intocockroachdb:masterfrom
Conversation
|
This change is |
a23b175 to
39764bf
Compare
fqazi
left a comment
There was a problem hiding this comment.
Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @ajwerner)
pkg/sql/schemachanger/scbuild/build.go line 101 at r1 (raw file):
// Exclude targets which are not yet usable in the currently active // cluster version. if !version.IsActive(screl.MinVersion(e.element)) {
Are there any concerns about funny side effects because of missing elements and transactions? We tend to stack states together when multiple statements are used.
We don't really support using the declarative schema changer in explicit transactions officially, and we don't support any statements where that is interesting in the mixed version state, so I'm not worried about it. |
fqazi
left a comment
There was a problem hiding this comment.
Reviewable status:
|
TFTR! bors r+ |
|
Build failed (retrying...): |
|
bors r- |
|
Canceled. |
|
Will fix #86659 |
|
TFTR! bors r+ |
|
Build failed (retrying...): |
|
bors r- |
|
Canceled. |
39764bf to
945c80d
Compare
|
Once #87459 is merged into master, I will rid it (commit 1) from this PR. After that we should be able to bors it. |
945c80d to
b736df1
Compare
Previously, the minimal supported version for stmt `ADD COLUMN` in the new schema changer was incorrectly labeled as v22.1, but this stmt was not fully supported and we added much functionality to it in v22.2. It was incompatible with the version gating elements commit (e.g. in a mixed version state, if we want to use new schema changer for an `ADD COLUMN` but the element `IndexColumn` was excluded due to the gating, then we will run into issues). This PR changes the minimal supported version of `ADD COLUMN` to v22.2. Release justification: bug fix Release note: None
We cannot create elements the old version of the code does not know about. Release justification: fixed mixed version incompatibility Release note: None
b736df1 to
7dbf545
Compare
|
bors r+ |
|
Build succeeded: |
Commit 1: fix minSupportedVersion of
ADD COLUMNin new schema changerfrom v22.1 to v22.2
Commit 2: We cannot create elements the old version of the code does not know about.
Release justification: fixed mixed version incompatibility
Release note: None