sql/gcjob: set GC hint when deleting all data in range#86739
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Sep 1, 2022
Merged
sql/gcjob: set GC hint when deleting all data in range#86739craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Member
|
This change is |
725e257 to
e8e4e98
Compare
Contributor
Author
|
Follow up to adding hint: #86550 |
Contributor
erikgrinaker
left a comment
There was a problem hiding this comment.
Let's set this in sql/planner.ForceDeleteTableData() too.
When deleting full range spans with range tombstones GC hint should be set to reduce the work GC does when collecting those ranges. This commit add appropriate flag to the request. Release justification: Enables future optimization for delete range only, doesn't change current GC or delete range functionality. Release note: None
e8e4e98 to
f318c48
Compare
erikgrinaker
approved these changes
Sep 1, 2022
Contributor
Author
|
bors r+ |
Contributor
|
Build failed: |
Contributor
Author
|
bors r+ |
Contributor
|
Build failed (retrying...): |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When deleting full range spans with range tombstones GC hint
should be set to reduce the work GC does when collecting those
ranges.
This commit add appropriate flag to the request.
Release justification: Enables future optimization for delete range only,
doesn't change current GC or delete range functionality.
Release note: None